Make relevant sort work for the tag edit cloud

Conversation 0 Commits 2 Files Changed 1

joe commented 1 year ago

Collaborator

fixes upstream #820

joe added 1 commit 1 year ago

5506739fde

append relevant tags to parameter array instead of binding array to parameter

butterbutt changed title from ~~Make relevant sort work for the tag edit cloud~~ to WIP: Make relevant sort work for the tag edit cloud 11 months ago

butterbutt requested changes 11 months ago

butterbutt left a comment

Owner

fix typos pls

ext/tag_editcloud/main.php Outdated

													
					                    return null;
				
					                }
				
					                $in = ":".implode(", :", array_keys($relevant_tags));;

butterbutt commented 11 months ago

Owner

lots of extra semicolons in this commit lol

ext/tag_editcloud/main.php

													
					                $in = ":".implode(", :", array_keys($relevant_tags));;
				
					                $params = ["tag_min1" => $tags_min, "tag_min2" => $tags_min, "limit" => $max_count];
				
					                foreach ($relevant_tags as $key=>$val) {
				
					                    ;

butterbutt commented 11 months ago

Owner

🤔

joe added 1 commit 11 months ago

1c581c0d75

remove stray semicolons

joe changed title from ~~WIP: Make relevant sort work for the tag edit cloud~~ to Make relevant sort work for the tag edit cloud 11 months ago

joe requested review from butterbutt 11 months ago

Reviewers

butterbutt was requested for review 11 months ago

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: butterbutt/shimmie2#3

Make relevant sort work for the tag edit cloud #3

Reviewers